[Sumtree]: Min Order Quantity

contracts/sumtree-orderbook/src/order.rs

@@ -105,16 +105,14 @@ pub fn place_limit(
     );
 
     let quant_dec256 = Decimal256::from_ratio(limit_order.quantity.u128(), Uint256::one());
-    // Only save the order if not fully filled
-    if limit_order.quantity > Uint128::zero() {
-        // Save the order to the orderbook
-        orders().save(deps.storage, &(tick_id, order_id), &limit_order)?;
 
-        tick_values.total_amount_of_liquidity = tick_values
-            .total_amount_of_liquidity
-            .checked_add(quant_dec256)
-            .unwrap();
-    }
+    // Save the order to the orderbook
+    orders().save(deps.storage, &(tick_id, order_id), &limit_order)?;
+
+    tick_values.total_amount_of_liquidity = tick_values
+        .total_amount_of_liquidity
+        .checked_add(quant_dec256)
+        .unwrap();
 
     tick_values.cumulative_total_value = tick_values
         .cumulative_total_value
@@ -669,9 +667,6 @@ pub(crate) fn claim_order(
     // Immutable amount to prevent bounty/maker fee calculations affecting each other
     let raw_amount = amount;
 
-    // Cannot send a zero amount, may be zero'd out by rounding
-    ensure!(!amount.is_zero(), ContractError::ZeroClaim);
-
     let denom = orderbook.get_opposite_denom(&order.order_direction);
 
     // Send claim bounty to sender if applicable
@@ -696,13 +691,17 @@ pub(crate) fn claim_order(
         amount = amount.checked_sub(maker_fee_amount)?;
     }
 
-    // Claimed amount always goes to the order owner
-    let bank_msg = MsgSend256 {
-        from_address: contract_address.to_string(),
-        to_address: order.owner.to_string(),
-        amount: vec![coin_u256(amount, &denom)],
-    };
-    let mut bank_msg_vec = vec![SubMsg::reply_on_error(bank_msg, REPLY_ID_CLAIM)];
+    let mut bank_msg_vec = vec![];
+    // Silently fail on zero claim (dust amount) orders
+    if !amount.is_zero() {
+        // Claimed amount always goes to the order owner
+        let bank_msg = MsgSend256 {
+            from_address: contract_address.to_string(),
+            to_address: order.owner.to_string(),
+            amount: vec![coin_u256(amount, &denom)],
+        };
+        bank_msg_vec.push(SubMsg::reply_on_error(bank_msg, REPLY_ID_CLAIM));
+    }
 
     if !bounty.is_zero() {
         // Bounty always goes to the sender