[Sumtree]: Min Order Quantity #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tick_values.total_amount_of_liquidity = tick_values | ||
| .total_amount_of_liquidity | ||
| .checked_add(quant_dec256) | ||
| .unwrap(); |
There was a problem hiding this comment.
Just realized – we should be returning the error here instead of unwrapping right?
| @@ -669,9 +667,6 @@ pub(crate) fn claim_order( | |||
| // Immutable amount to prevent bounty/maker fee calculations affecting each other | |||
| let raw_amount = amount; | |||
|
|
|||
| // Cannot send a zero amount, may be zero'd out by rounding | |||
| ensure!(!amount.is_zero(), ContractError::ZeroClaim); | |||
|
|
|||
There was a problem hiding this comment.
Since we are skipping this check now, we should also probably be skipping the bounty & maker fee calculations if the amount is zero right?
AlpinYukseloglu
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In the current implementation when placing a limit it is possible to place an order with a quantity small enough that when claiming the order a
ZeroClaimerror is thrown due to the order not being enough to fill a single unit. These changes cause these types of orders to silently fail, ignoring the claim of the dust amount.Testing and Verifying
Several tests were updated to accommodate for this change and a min quantity test case was added for placing a limit.