Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(steps): add axe tests, correct steps aria #846

Merged
merged 11 commits into from
Mar 19, 2024
Merged

tests(steps): add axe tests, correct steps aria #846

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8ea8ffa
Add axe tests for step component, correct steps aria
mmazanec22 Mar 7, 2024
c7548d1
Remove aria-selected
mmazanec22 Mar 7, 2024
730a6c1
Make jest axe a dev dependency instead
mmazanec22 Mar 12, 2024
df2b1fd
Remove alert func
mmazanec22 Mar 12, 2024
7492397
Add jest axe types
mmazanec22 Mar 12, 2024
13d812f
Add jest axe types to package lock
mmazanec22 Mar 12, 2024
5bcafc1
Remove explicit fallthrough attributes
mmazanec22 Mar 12, 2024
c513a2c
Add vitest setup
mmazanec22 Mar 12, 2024
2048c6d
Resolve rebase package lock issue
mmazanec22 Mar 13, 2024
1dca537
Rename axe steps test file
mmazanec22 Mar 15, 2024
7edf5c1
Describe axe tests more accurately
mmazanec22 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
261 changes: 259 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/oruga/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"@rollup/plugin-babel": "6.0.4",
"@types/node": "^20.11.25",
"@vitejs/plugin-vue": "^5.0.4",
"@types/jest-axe": "^3.5.9",
"@vitest/coverage-istanbul": "^1.3.1",
"@vue/eslint-config-prettier": "^9.0.0",
"@vue/eslint-config-standard": "^8.0.1",
Expand All @@ -91,6 +92,7 @@
"eslint-plugin-vuejs-accessibility": "^2.2.1",
"happy-dom": "^13.6.2",
"npm-check-updates": "^16.14.15",
"jest-axe": "^8.0.0",
"prettier": "^3.2.5",
"rimraf": "^5.0.5",
"sass": "1.71.1",
Expand All @@ -104,4 +106,4 @@
"vue-component-type-helpers": "^2.0.6",
"vue-tsc": "^2.0.6"
}
}
}
4 changes: 4 additions & 0 deletions packages/oruga/src/__tests__/vitest.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { expect } from "vitest";
import { toHaveNoViolations } from "jest-axe";

expect.extend(toHaveNoViolations);
10 changes: 5 additions & 5 deletions packages/oruga/src/components/steps/Steps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,15 +475,15 @@ function itemClasses(childItem: (typeof items.value)[number]): ClassBind[] {

<template>
<div :class="rootClasses" data-oruga="steps">
<ol
:class="wrapperClasses"
:aria-orientation="vertical ? 'vertical' : 'horizontal'">
<ol :class="wrapperClasses">
<li
v-for="(childItem, index) in items"
v-show="childItem.visible"
:key="childItem.value"
:class="itemClasses(childItem)"
:aria-selected="childItem.value === activeItem.value">
:aria-current="
childItem.value === activeItem.value ? 'step' : undefined
"
:class="itemClasses(childItem)">
<span v-if="index > 0" :class="stepDividerClasses"> </span>

<component
Expand Down
Loading
Loading