-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(steps): add axe tests, correct steps aria #846
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/oruga/src/components/steps/tests/steps.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/oruga/src/components/steps/tests/steps.integration.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #846 +/- ##
============================================
- Coverage 56.71% 10.52% -46.20%
============================================
Files 30 110 +80
Lines 1511 5273 +3762
Branches 544 1917 +1373
============================================
- Hits 857 555 -302
- Misses 654 3740 +3086
- Partials 0 978 +978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
An example of using Deque's axe library (via jest-axe) to test accessibility for a component (see #596 ). Also fixes an accessibility issue for the steps component. Modeled after #841, assuming that more tests will be added following this pattern.
Proposed Changes