Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(steps): add axe tests, correct steps aria #846

Merged
merged 11 commits into from
Mar 19, 2024

Conversation

mmazanec22
Copy link
Contributor

@mmazanec22 mmazanec22 commented Mar 7, 2024

An example of using Deque's axe library (via jest-axe) to test accessibility for a component (see #596 ). Also fixes an accessibility issue for the steps component. Modeled after #841, assuming that more tests will be added following this pattern.

Proposed Changes

  • Use jest-axe to test accessibility of the Steps component given different props scenarios
  • Remove the aria-orientation role, as it is not valid on this component
  • Add the aria-current property

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 7edf5c1
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65f4731542a61900078505cf
😎 Deploy Preview https://deploy-preview-846--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 10.52%. Comparing base (484cfe8) to head (7edf5c1).
Report is 26 commits behind head on develop.

Files Patch % Lines
.../oruga/src/components/steps/tests/StepsExample.vue 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #846       +/-   ##
============================================
- Coverage    56.71%   10.52%   -46.20%     
============================================
  Files           30      110       +80     
  Lines         1511     5273     +3762     
  Branches       544     1917     +1373     
============================================
- Hits           857      555      -302     
- Misses         654     3740     +3086     
- Partials         0      978      +978     
Flag Coverage Δ
oruga-next 10.52% <73.33%> (-46.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title Add axe tests for step component, correct steps aria tests(steps): add axe tests, correct steps aria Mar 13, 2024
@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality a11y Accessibility labels Mar 13, 2024
@mlmoravek mlmoravek merged commit 8f93c80 into oruga-ui:develop Mar 19, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants