-
Notifications
You must be signed in to change notification settings - Fork 778
file content/genre API #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file content/genre API #3050
Conversation
- no line number support fixes oracle#3048
- crude version using class variable
- add endpoint for genre - rename FileContentController to FileController
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/index/IndexDatabase.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/test/java/org/opengrok/web/api/v1/controller/FileControllerTest.java
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test with curl also on escaped path parameter? file/content?path=opengrok%2Fsrc%2Fmain%2Ffile
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/FileController.java
Outdated
Show resolved
Hide resolved
works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change implements API endpoints for retrieving file content and genre. There is no paging support.
I refactored the authorization introduced for the history API endpoint so that it can be used via annotations.
Demo: