Skip to content

Annotation API #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2020
Merged

Annotation API #3056

merged 3 commits into from
Mar 12, 2020

Conversation

vladak
Copy link
Member

@vladak vladak commented Feb 26, 2020 •
edited
Loading

This change add simple annotation API.

Limitations:

  • no support for paging
  • description is HTML encoded

While testing I found out that Git annotations are broken so fix for that is included.

tulinkry
tulinkry reviewed Feb 26, 2020
View reviewed changes
idodeclare
idodeclare approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@idodeclare idodeclare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladak
Copy link
Member Author

vladak commented Mar 6, 2020

LGTM

Thanks, this was nice learning experience.

@vladak vladak merged commit c4679de into oracle:master Mar 12, 2020
@vladak vladak deleted the annotation_API branch March 12, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulinkry tulinkry tulinkry approved these changes

@idodeclare idodeclare idodeclare requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladak @idodeclare @tulinkry