Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10198] odp not integrated error #262

Merged
merged 5 commits into from
May 22, 2024

Conversation

junaed-optimizely
Copy link
Contributor

Summary

If the project does not have ODP integration enabled, sdk should not call the fetchQualifiedSegments method.

Test plan

Existing test should pass

Issues

FSSDK-10198

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/client.ts Outdated Show resolved Hide resolved
@junaed-optimizely junaed-optimizely changed the title Junaed/fssdk 10198 odp not integrated error [FSSDK-10198] odp not integrated error May 21, 2024
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the dependencies.

yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please check your specific error is corrected. You might also note that in the PR description as part of manual acceptance testing.

src/client.ts Show resolved Hide resolved
@junaed-optimizely junaed-optimizely merged commit d2f14bd into master May 22, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10198-odp-not-integrated-error branch May 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants