Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional eventBatchSize and eventFlushInterval #176

Closed
mthorne-godaddy opened this issue Jul 27, 2022 · 7 comments
Closed

Optional eventBatchSize and eventFlushInterval #176

mthorne-godaddy opened this issue Jul 27, 2022 · 7 comments

Comments

@mthorne-godaddy
Copy link

Hi, as per the docs the eventBatchSize and eventFlushInterval seem optional in 2.9.0

This is confirmed by the type definitions:

Screenshot 2022-07-27 at 12 03 57

However, I'm getting the following console warnings:

[OPTIMIZELY] - WARN  2022-07-27T10:01:02.068Z Invalid eventBatchSize undefined, defaulting to 10
[OPTIMIZELY] - WARN  2022-07-27T10:01:02.068Z Invalid eventFlushInterval undefined, defaulting to 1000

Related to: #175

@mthorne-godaddy
Copy link
Author

@opti-jnguyen @opti-josh-holt 👋 Are either of you able to please assist with the above and #175? Or let me know who else I can ask. Thank you.

@lenniecottrell
Copy link

This and #175 have been picked up by Optimizely support 👍

@Tamara-Barum
Copy link

Closing as per Opti Support update

@arthurdenner
Copy link

Hi everyone! Can we watch the progress once the support team picks it up?
The latest version published on npm is 2.9.2 (from March 2023) and it still logs these warnings.

@camjackson
Copy link

Just adding to the chorus, I don't think this should have been closed. I'm using the latest version of the react SDK (3.1.0), which logs these warnings despite the configs supposedly being optional. It's very annoying. Either the configs should be mandatory, or those logs should not be emitted.

There's also this error:

client.js:1 [OPTIMIZELY] - ERROR 2024-05-19T10:32:41.837Z undefined: ODP is not integrated

I had to spend ages reading through the SDK source config in order to figure out that I need to pass odpOptions: { disabled: true } when initialising the client. I feel like this error should only occur if I've explicitly tried to enable ODP without configuring it properly. If I haven't tried to enable or configure ODP at all, then it should just silently be disabled, not log errors.

@mikechu-optimizely
Copy link
Contributor

We've tested #262 which depends on JS PR #930 We anticipate should resolve this error.

@camjackson
Copy link

Thanks @mikechu-optimizely, that's great to hear that the ODP issue will be fixed. What about the other two warnings originally mentioned in this issue? For eventBatchSize and eventFlushInterval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants