Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross referencing blogs in genai samples readme #1399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

Cross referencing blogs in genai samples readme #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88efb19
blogs cross-referencing for image generation (python part)
DimaPastushenkov Dec 17, 2024
4baaf88
blogs cross-referencing for image generation (c++ part)
DimaPastushenkov Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions samples/cpp/image_generation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ Users can change the sample code and play with the following generation paramete
> [!NOTE]
> Image generated with HuggingFace / Optimum Intel is not the same generated by this C++ sample: C++ random generation with MT19937 results differ from `numpy.random.randn()` and `diffusers.utils.randn_tensor` (uses `torch.Generator` inside). So, it's expected that image generated by Diffusers and C++ versions provide different images, because latent images are initialize differently.

## OpenVINO blogs about Image Generation with GenAI

Please follow the following blogs to setup your first hands-on experience with samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have Follow [Get Started with Samples](https://docs.openvino.ai/2024/learn-openvino/openvino-samples/get-started-demos.html) to run the sample below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov, but https://docs.openvino.ai/2024/learn-openvino/openvino-samples/get-started-demos.html isn't related to OpenVINO GenAI scenarios, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenVINO and OpenVINO GenAI samples have the same build instructions.
All other steps how to run samples are located within this README.md.

I don't understand why should we refer to some blogs, while we have our own documentation.
The goal of blogs is to advertise OpenVINO; while referring to blogs from our docs, we advertise medium.com.


* [How to generate images locally on AI PC with OpenVINO GenAI API](https://medium.com/openvino-toolkit/how-to-generate-images-locally-on-ai-pc-with-openvino-genai-api-220d08370958)

## Download and convert the models and tokenizers

The `--upgrade-strategy eager` option is needed to ensure `optimum-intel` is upgraded to the latest version.
Expand Down
6 changes: 6 additions & 0 deletions samples/python/image_generation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ Users can change the sample code and play with the following generation paramete
> OpenVINO GenAI is written in C++ and uses `CppStdGenerator` random generator in Image Generation pipelines, while Diffusers library uses `torch.Generator` underhood.
> To have the same results with HuggingFace, pass manually created `torch.Generator(device='cpu').manual_seed(seed)` to Diffusers generation pipelines and `openvino_genai.TorchGenerator(seed)` to OpenVINO GenAI pipelines as value for `generator` kwarg.

## OpenVINO blogs about Image Generation with GenAI

Please follow the following blogs to setup your first hands-on experience with samples.

* [How to generate images locally on AI PC with OpenVINO GenAI API](https://medium.com/openvino-toolkit/how-to-generate-images-locally-on-ai-pc-with-openvino-genai-api-220d08370958)

## Download and convert the models and tokenizers

The `--upgrade-strategy eager` option is needed to ensure `optimum-intel` is upgraded to the latest version.
Expand Down
Loading