Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross referencing blogs in genai samples readme #1399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DimaPastushenkov
Copy link
Contributor

Cross referencing blogs in genai samples readme

@github-actions github-actions bot added the category: samples GenAI samples label Dec 17, 2024
@@ -24,6 +24,12 @@ Users can change the sample code and play with the following generation paramete
> [!NOTE]
> Image generated with HuggingFace / Optimum Intel is not the same generated by this C++ sample: C++ random generation with MT19937 results differ from `numpy.random.randn()` and `diffusers.utils.randn_tensor` (uses `torch.Generator` inside). So, it's expected that image generated by Diffusers and C++ versions provide different images, because latent images are initialize differently.

## OpenVINO blogs about Image Generation with GenAI

Please follow the following blogs to setup your first hands-on experience with samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have Follow [Get Started with Samples](https://docs.openvino.ai/2024/learn-openvino/openvino-samples/get-started-demos.html) to run the sample below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenVINO and OpenVINO GenAI samples have the same build instructions.
All other steps how to run samples are located within this README.md.

I don't understand why should we refer to some blogs, while we have our own documentation.
The goal of blogs is to advertise OpenVINO; while referring to blogs from our docs, we advertise medium.com.

@ilya-lavrenov ilya-lavrenov self-assigned this Dec 17, 2024
@helena-intel
Copy link
Contributor

Is there a mechanism in place to make sure these blogs are kept up-to-date with new OpenVINO releases? It's unfortunate enough that people run into issues quite regularly when they stumble upon old blogs that explain how to do something, but if we're linking to these blogs from our repositories, we should make sure they work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: samples GenAI samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants