-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding snippets directory and all required symbolic links #39854
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 2e9b9d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fadd697402d80007075a8e 😎 Browse the preview: https://deploy-preview-39854--osdocs.netlify.app |
@vikram-redhat Given the nature of this change, I am asking that you peer review this. I was thinking that it might be a good idea to begin adoption of text snippets with 4.10 to avoid any issues that might arise going as far back as 4.6. WDYT? |
@mjpytlak this works for me. Do you mean to say that you will merge this only for 4.10? |
Yes. I am proposing that we adopt text snippets as of 4.10. I was concerned about back porting and running into issues. Am I overthinking it? |
@vikram-redhat, this doesn't count as a module in the CCS guidelines and is thus permissible? Or are we not concerned about that any longer. For all intents in purposes, this is just structured use of an |
Good morning, @jboxman-rh. If you have not had a chance, PTAL at #38393. I had updated our guidelines around usage. |
@jboxman I don't think there are any issues around using text snippets, in any platform. @kalexand-rh can you confirm if Jupiter has any restrictions on this? @mjpytlak if we do merge it, I think we should backport it to avoid conflicts. |
@vikram-redhat, well, a snippet is just an include. So this all formalizes what to Asciidoctor is just a thing, that it does. But it isn't necessarily a thing every 'platform' will do, so I don't want to keep digging if it presents an issue. |
@vikram-redhat, Jupiter doesn't care if you use snippets. It's just another include. I don't think they've decided if they're going to store it as a separate node, but they've confirmed that snippets will be transformed correctly during the ingest phase. |
You are right. We know how it can be with other "platforms" :). |
2204523
to
4b099c9
Compare
4b099c9
to
0d752fc
Compare
@kalexand-rh Rebased and resolved references to |
@mjpytlak, moving this back to 4.6 will be best. |
0d752fc
to
7f9aadf
Compare
7f9aadf
to
2e9b9d8
Compare
This PR is a follow on effort to enabling the use of text snippets. While PR 38393 updated the OpenShift documentation guidelines on how to use text snippets. This PR prepares the repository for their adoption.
Material changes.
technology-preview.adoc
was moved from the top-levelmodules
directory to a new top-levelsnippets
directory.technology-preview.adoc
have been updated to reference the new location. All files where tested locally and look good.snippets
directory has been added to all remaining content directories, enabling the use of text snippets.Doc preview of topics using
technology-preview.adoc