Add snippets symlink in modules dir #41466
Conversation
openshift-ci
bot
added
the
size/S
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 9ac05fd 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fdb106216e340008ea20c3 😎 Browse the preview: https://deploy-preview-41466--osdocs.netlify.app |
adellape
force-pushed
the
snippets-symlink-guideline
branch
from
ce4c75b to
e255ce8
Compare
| [source,text] | ||
| ---- | ||
| :FeatureName: The XYZ plug-in | ||
| \include::snippets/technology-preview.adoc[] |
There was a problem hiding this comment.
Do you need the \ here?
Will you fix the typo on line 110?
Otherwise, this LGTM!
There was a problem hiding this comment.
Yea, it escapes the include directive, otherwise it renders like:
Will fix the line 110 ordered numbering too. 👍
adellape
force-pushed
the
snippets-symlink-guideline
branch
from
e255ce8 to
01759d7
Compare
adellape
changed the title
adellape
force-pushed
the
snippets-symlink-guideline
branch
from
01759d7 to
633055c
Compare
adellape
force-pushed
the
snippets-symlink-guideline
branch
from
633055c to
9ac05fd
Compare
openshift-ci
bot
added
size/XS
|
Updated this PR to just be about the symlink, and split the repo guideline TP edits to #41477. |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
@adellape: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.10 from head openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.10 and openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.10"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.9 from head openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.9 and openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.9"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.8 from head openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.8 and openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.8"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.7 from head openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.7 and openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.6 and openshift-cherrypick-robot:cherry-pick-41466-to-enterprise-4.6"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The cherry-picks failed seemingly because the symlinks are already in those branches. So I suppose what maybe happened was the symlink wasn't created in the |
Text snippets are allowed in modules, but they need a symlink from the
modules/directory to thesnippets/directory if they're going to be included with a relative reference in the following form:Also update the Tech Preview example in the guidelines since the old PR-link example was using the formermodules/directory and showing aleveloffsetthat I don't think we need.^ Actually gonna do this in a separate PR (#41477) because of branch drift for the guidelines file.