Skip to content

OCPBUGS-54458: fix unit test failure caused by coreos/etcd removing latest tag #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

OCPBUGS-54458: fix unit test failure caused by coreos/etcd removing latest tag #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/image/apiserver/importer/import_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func TestImageStreamImportQuayIO(t *testing.T) {
rt, _ := restclient.TransportFor(&restclient.Config{})
importCtx := importer.NewStaticCredentialsContext(rt, nil, nil)

repositoryName := quayRegistryName + "/coreos/etcd"
repositoryName := quayRegistryName + "/coreos/etcd-operator"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we change the repositoryName from etcd to etcd-operator, this problem is caused by issue etcd-io/etcd#15382, one fixed etcd version is suggessted for end user's requirement.
I fixed it in PR 8ddda1a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will close this PR.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QiWang19 I double checked the test TestImageStreamImportQuayIO which has nothing to do with etcd image, I agree with your code chage.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/reopen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coreos organization in quay has been for the most abandoned since the acquisition of CoreOS and the etcd-operator image hasn't been updated in 6-7 years so there is a change that the unit test might fail again in the future if the organization is ever cleaned up.

What would you think about using quay.io/projectquay/quay:3.13.4 instead? This is the official image for quay so it is more likely to remain available forever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would require changing the logic of the this test case, it seems the current test case does not specify the tag, just relies on the latest tag of the repository instead.
I would leave this to the openshift-apiserver to take a look if this change is needed.

Copy link
Member

@dgrisonnet dgrisonnet Apr 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test, it doesn't seem important whether the target image has the "latest" tag or another and since there is now precedence for the latest tag to be removed, we might as well just use a fixed tag that we know will never change / be removed.

I would leave this to the openshift-apiserver to take a look if this change is needed.

I am one of the approver for openshift-apiserver. Technically the change I suggested is not necessary to address the issue at end and using the etcd-operator would work, but since we need to update the image or the tag anyway, we might aswell just use one that we know will never disappear.

Copy link
Member Author

@QiWang19 QiWang19 Apr 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrisonnet Could someone from the OpenShift API Server team take over this bug fix? If so, I'll close my PR.
backport PR #500 is blocked by this issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people are out because of KubeCon so it might difficult, but I can take over early next week. Feel free to reach out to me on slack if I forget about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrisonnet thanks, I assigned OCPBUGS-54458 to you.

imports := &imageapi.ImageStreamImport{
Spec: imageapi.ImageStreamImportSpec{
Images: []imageapi.ImageImportSpec{
Expand Down