OCPBUGS-54458: fix unit test failure caused by coreos/etcd removing latest tag #503
Conversation
Signed-off-by: Qi Wang <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test unit |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
| @@ -93,7 +93,7 @@ func TestImageStreamImportQuayIO(t *testing.T) { | |||
| rt, _ := restclient.TransportFor(&restclient.Config{}) | |||
| importCtx := importer.NewStaticCredentialsContext(rt, nil, nil) | |||
|
|
|||
| repositoryName := quayRegistryName + "/coreos/etcd" | |||
| repositoryName := quayRegistryName + "/coreos/etcd-operator" | |||
There was a problem hiding this comment.
Why do we change the repositoryName from etcd to etcd-operator, this problem is caused by issue etcd-io/etcd#15382, one fixed etcd version is suggessted for end user's requirement.
I fixed it in PR 8ddda1a
There was a problem hiding this comment.
Thanks! I will close this PR.
There was a problem hiding this comment.
@QiWang19 I double checked the test TestImageStreamImportQuayIO which has nothing to do with etcd image, I agree with your code chage.
There was a problem hiding this comment.
The coreos organization in quay has been for the most abandoned since the acquisition of CoreOS and the etcd-operator image hasn't been updated in 6-7 years so there is a change that the unit test might fail again in the future if the organization is ever cleaned up.
What would you think about using quay.io/projectquay/quay:3.13.4 instead? This is the official image for quay so it is more likely to remain available forever.
There was a problem hiding this comment.
I think this would require changing the logic of the this test case, it seems the current test case does not specify the tag, just relies on the latest tag of the repository instead.
I would leave this to the openshift-apiserver to take a look if this change is needed.
There was a problem hiding this comment.
Looking at the test, it doesn't seem important whether the target image has the "latest" tag or another and since there is now precedence for the latest tag to be removed, we might as well just use a fixed tag that we know will never change / be removed.
I would leave this to the openshift-apiserver to take a look if this change is needed.
I am one of the approver for openshift-apiserver. Technically the change I suggested is not necessary to address the issue at end and using the etcd-operator would work, but since we need to update the image or the tag anyway, we might aswell just use one that we know will never disappear.
There was a problem hiding this comment.
@dgrisonnet Could someone from the OpenShift API Server team take over this bug fix? If so, I'll close my PR.
backport PR #500 is blocked by this issue
There was a problem hiding this comment.
Some people are out because of KubeCon so it might difficult, but I can take over early next week. Feel free to reach out to me on slack if I forget about it
There was a problem hiding this comment.
@dgrisonnet thanks, I assigned OCPBUGS-54458 to you.
|
@wangke19: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/assign @dgrisonnet |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: QiWang19, wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
QiWang19
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@QiWang19: This pull request references Jira Issue OCPBUGS-54458, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@QiWang19: This pull request references Jira Issue OCPBUGS-54458, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@QiWang19: This pull request references Jira Issue OCPBUGS-54458. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Use
quay.io/coreos/etcd-operatorrepository in the test. The unit test TestImageStreamImportQuayIO failed becausequay.io/coreos/etcdremoves the latest tag.