[release-4.17] OCPBUGS-53382: Skip blocked registry check for registries with mirrors

[openshift-cherrypick-robot]

This is an automated cherry-pick of #498

/assign QiWang19

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-52312 has been cloned as Jira Issue OCPBUGS-53382. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-53382: Skip blocked registry check for registries with mirrors

In response to this:

This is an automated cherry-pick of #498

/assign QiWang19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53382, which is invalid:

• expected dependent Jira Issue OCPBUGS-52312 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #498

/assign QiWang19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

/test unit

[flavianmissi]

/label backport-risk-assessed
/lgtm

[openshift-ci]

@flavianmissi: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/image/OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[QiWang19]

/test unit

[QiWang19]

@flavianmissi The unit test failure is not related to this code changes, do you have idea how this test should get fixed? 🤔

[flavianmissi]

Yeah that's a weird failure, @QiWang19 . Have you seen it fail locally as well? Does it only happen in the 4.17 branch?
The failure doesn't say much... I don't know how to fix it.
If it's only failing in 4.17 then we'd need to surgically fix it in that branch directly (via PR as usual), and we'll probably need a staff engineer to help us merge the hypothetical PR, since automation would not allow us to do this without other PRs against 4.18 and main.

EDIT: another option is to override, then try to fix it, but I don't have permission for doing so.

[QiWang19]

@flavianmissi This test failed 4.17, 4.18, and the current master branch.(#502). Tests TestImageStreamImportQuayIO ran locally also failed on these branches.

[flavianmissi]

Thanks for checking, @QiWang19. Ideally, we would fix the tests then pull the changes here, but it's probably also possible to override fhe failure here since it's failing in multiple branches. I'm not a maintainer of this repo (only the image api bits), so it's best to ask for what the maintainers recommend as next step in the forum-api-review slack channel. Feel free to tag me there.

[QiWang19]

/jira refresh

[openshift-ci-robot]

@QiWang19: This pull request references Jira Issue OCPBUGS-53382, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-52312 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52312 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xiuwang]

/retest

[openshift-ci]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	d59ecba	link	true	/test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xiuwang]

/label qe-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53382, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-52312 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52312 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

This is an automated cherry-pick of #498

/assign QiWang19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xiuwang]

/label cherry-pick-approved

[openshift-ci]

@xiuwang: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[QiWang19]

This PR currently blocked by master branch bug OCPBUGS-54458

[wangke19]

/label cherry-pick-approved