[WIP] OCPBUGS-45729: Updating ose-openshift-apiserver-container image to be consistent with ART for 4.19 #486
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
wangke19
force-pushed
the
go-version-update
branch
from
be4c90e to
4616af6
Compare
|
/reopen |
|
@wangke19: Failed to re-open PR: state cannot be changed. There are no new commits on the wangke19:go-version-update branch. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@wangke19: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test verify |
wangke19
force-pushed
the
go-version-update
branch
2 times, most recently
from
090ae8e to
a8a780f
Compare
|
/retest |
1 similar comment
|
/retest |
wangke19
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@wangke19: This pull request references Jira Issue OCPBUGS-45729, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @dgrisonnet |
|
You need to update the container image, similarly to: https://github.com/openshift/openshift-apiserver/pull/490/files |
|
@dgrisonnet We tried that #464, in which pr test are not passing |
|
Looking at the failure on the other PR, you need to run |
|
We tried that, but without library update that was failing |
wangke19
force-pushed
the
go-version-update
branch
from
a8a780f to
9353b74
Compare
Done, let's see results of ci jobs. |
wangke19
force-pushed
the
go-version-update
branch
from
9353b74 to
339f0cf
Compare
|
/retest |
wangke19
force-pushed
the
go-version-update
branch
2 times, most recently
from
8ebd58b to
698d1c7
Compare
|
Hold this PR for further investigation. |
openshift-ci
bot
added
the
do-not-merge/hold
wangke19
force-pushed
the
go-version-update
branch
from
698d1c7 to
8ddda1a
Compare
wangke19
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@wangke19: This pull request references Jira Issue OCPBUGS-45729, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: wangke19. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
wangke19
force-pushed
the
go-version-update
branch
from
7c1aac1 to
4d86479
Compare
|
Depends on openshift/kubernetes-apiserver#65 |
|
@wangke19 You will need to update the go.mod to reference my commit in this PR. This PR will serve as a proof for k8s-apiserver PR. If this PR passes CI, then k8s-apiserver PR can be merged. |
|
@dinhxuanvu I updated k8s.io/apiserver reference of openshift/kubernetes-apiserver#65, will run tests to look the results. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-ovn-serial |
|
@dinhxuanvu Do you have any suggestions for failed |
wangke19
force-pushed
the
go-version-update
branch
from
1f5c005 to
231a2b8
Compare
|
/test e2e-aws-ovn-builds |
|
/test okd-scos-e2e-aws-ovn |
1 similar comment
|
/test okd-scos-e2e-aws-ovn |
|
@wangke19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| }, | ||
| }, | ||
| } | ||
| if errs = kapivalidation.ValidateResourceQuota(quota); len(errs) > 0 { |
There was a problem hiding this comment.
I would like to ask why you added this block of code to validate resource limits? The func ValidateResourceQuota actually validate ObjectMeta as well which leads to all of failures on unit tests due to the fact this RQ object doesn't have name or namespace values which are required.
Also please separate the vendor code change to one commit and your own changes to another commit. This commit is so big. It is very hard to review as browser can't load such a big diff.
What does the PR do:
image quay.io/coreos/etcd:latest not found, due to Image with 'latest' tag corresponds to an older etcd version etcd-io/etcd#15382