OTA-1403: Update and Verify Test Metadata Using Makefile #1179
+55
−21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| [ | ||
| { | ||
| "name": "[cvo-testing] cluster-version-operator-tests should support passing tests", | ||
| "labels": {}, | ||
| "resources": { | ||
| "isolation": {} | ||
| }, | ||
| "source": "openshift:payload:cluster-version-operator", | ||
| "lifecycle": "blocking", | ||
| "environmentSelector": {} | ||
| } | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,29 +2,11 @@ | |
|
|
||
| set -eu | ||
|
|
||
| # Go to the root of the repo | ||
| cd "$(git rev-parse --show-cdup)" | ||
|
|
||
| # Source build variables | ||
| source hack/build-info.sh | ||
|
There was a problem hiding this comment. I was wondering if there was a way to set up this import without relying on "assume |
||
|
|
||
| echo "Building binaries into ${BIN_PATH}" | ||
| mkdir -p ${BIN_PATH} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eu | ||
|
|
||
| REPO=github.com/openshift/cluster-version-operator | ||
| GOFLAGS=${GOFLAGS:--mod=vendor} | ||
| GLDFLAGS=${GLDFLAGS:-} | ||
|
|
||
| eval $(go env | grep -e "GOHOSTOS" -e "GOHOSTARCH") | ||
|
|
||
| GOOS=${GOOS:-${GOHOSTOS}} | ||
| GOARCH=${GOARCH:-${GOHOSTARCH}} | ||
|
|
||
| VERSION_OVERRIDE=${VERSION_OVERRIDE:-${OS_GIT_VERSION:-}} | ||
| if [ -z "${VERSION_OVERRIDE:-}" ]; then | ||
| echo "Using version from git..." | ||
| VERSION_OVERRIDE=$(git describe --abbrev=8 --dirty --always) | ||
| fi | ||
|
|
||
| eval $(go env) | ||
|
|
||
| if [ -z ${BIN_PATH+a} ]; then | ||
| export BIN_PATH=_output/${GOOS}/${GOARCH} | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eu | ||
|
|
||
| source hack/build-info.sh | ||
|
|
||
| # Update test metadata | ||
| eval "${BIN_PATH}/cluster-version-operator-tests" "update" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
.openshift-tests-extension/openshift_payload_cluster-version-operator.jsonpath here diverges from thehack/.openshift-tests-exension/product/type/component/*pattern claimed by the extension you'd linked from the pull-request opening comment. Is the extension text stale? Is ourcluster-version-operator-testsbinary feeding the wrong location? Other? I guess the update logic living in a vendored directory tips us towards "enhancement text is stale"?