OTA-1403: Update and Verify Test Metadata Using Makefile

[DavidHurta]

Create an update target in the Makefile to execute the tests-extension update logic to update/validate test metadata. Add git diff logic to the verify target to make sure any uncommitted changes fail the execution of the target. This will be run on PRs to make sure the test metadata is commited and valid.

For more info on the update subcommand, see Update - Metadata Validation

[openshift-ci-robot]

@DavidHurta: This pull request references OTA-1403 which is a valid jira issue.

In response to this:

Create an update target in the Makefile to execute the tests-extension update logic to update/validate test metadata. Add git diff logic to the verify target to make sure any uncommitted changes fail the execution of the target. This will be run on PRs to make sure the test metadata is commited and valid.

For more info on the update subcommand, see Update - Metadata Validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DavidHurta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DavidHurta]

I am gonna wait for https://www.github.com/openshift/cluster-version-operator/pull/1177 to merge before requesting a review.

[DavidHurta]

/hold

Wait for openshift/release#63274 to merge.

I do not want to mix additional logic into the verify job while it's getting functional.

[DavidHurta]

/unhold

[DavidHurta]

/label no-qe

The code adds metadata and new make targets. Nothing that requires QE capacity. The PR updates the script, which is used to build the CVO; however, only refactoring is made. Regression should be observable by a failing CI due to a failed image build.

[openshift-ci]

@DavidHurta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	a90e78e	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-agnostic-operator-devpreview	a90e78e	link	false	/test e2e-agnostic-operator-devpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wking]

I was wondering if there was a way to set up this import without relying on "assume build-go.sh is being called from the repository's root directory". But it seems like there may not be, so probably fine to stick with that assumption and not worry about the BASH_SOURCE and similar semi-reliable approaches.

[wking]

The .openshift-tests-extension/openshift_payload_cluster-version-operator.json path here diverges from the hack/.openshift-tests-exension/product/type/component/* pattern claimed by the extension you'd linked from the pull-request opening comment. Is the extension text stale? Is our cluster-version-operator-tests binary feeding the wrong location? Other? I guess the update logic living in a vendored directory tips us towards "enhancement text is stale"?