Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge coverage CI showing right percentage #759

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Jan 2, 2025

Description

Ignore x-ignorable specs in evaluated operations

Issues Resolved

[#748]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Changes Analysis

Commit SHA: c147c7e
Comparing To SHA: 0e0e072

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12584903792/artifacts/2379292656

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Spec Test Coverage Analysis

Total Tested
539 539 (100 %)

@Tokesh Tokesh added the skip-changelog No need to update CHANGELOG. label Jan 2, 2025
@Tokesh Tokesh marked this pull request as ready for review January 2, 2025 15:43
@Tokesh
Copy link
Collaborator Author

Tokesh commented Jan 2, 2025

Let me add some context; I think it will be helpful.

The Merge Coverage CI was showing over 100% (you can check details from issue) because the operations did not account for specs with x-ignorable:true, but these specs were included in evaluated_operations.

One of the solutions was to ensure they were excluded from evaluated_operations. This could have been implemented in various ways, but to avoid duplicating a lot of code and altering already defined structures, it was simpler to filter them at the point where they are accounted for.

@dblock dblock merged commit 3d88921 into opensearch-project:main Jan 2, 2025
38 of 39 checks passed
@dblock
Copy link
Member

dblock commented Jan 2, 2025

👏

I merged a little too fast, you should add a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants