-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spec with x-ignorable:true
to check Evaluation operations
#762
Conversation
Signed-off-by: Tokesh <[email protected]>
Changes AnalysisCommit SHA: 8238c0c API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12610531929/artifacts/2385752607 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I merge this test without your fix in #759 no tests will fail. So add a JavaScroipt/code test specifically for the "it will appear in operations and evaluated_operations on the existing tests" part.
Hi! The tests don’t fail because the code dynamically works only with As far as I understand, when running unit tests, we’re not starting an OpenSearch instance, correct? If so, implementing this on the current infrastructure would be challenging. It might be necessary to create a special type of test that runs alongside OpenSearch. |
For a unit test you want something a lot lower level and simpler and intentional. The method you changed was descrive('evaluatied_operations', () => {
test('does not include x-ignorable APIs', () => {
expect(test_results.evaluated_operations()).to ...
})
}) |
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
Description
I'm adding a spec with the parameter
x-ignorable:true
to see if it will appear inoperations
andevaluated_operations
on the existing tests.debt from #759
Issues Resolved
[#748]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.