Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Editing API v2 #1576

Closed
clepski opened this issue Sep 30, 2024 · 1 comment
Closed

Support the Editing API v2 #1576

clepski opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels

Comments

@clepski
Copy link
Collaborator

clepski commented Sep 30, 2024

Is your feature request related to a problem? Please describe.
As a plugin developer I want to use the Editing API v2.

Describe the solution you'd like
Open SCD should support the Editing API v2.

Requirements

  • Edit Events conforming to API v2 should be applied the SCD file and create the usual history entries

Suggestions for a specific user interaction

The code for the API v2 is already present in the old Editing Mixin, see https://github.com/openscd/open-scd/blob/main/packages/core/mixins/Editing.ts
We should transfer this code to the Editor Addon https://github.com/openscd/open-scd/blob/main/packages/openscd/src/addons/Editor.ts and support both Editing v1 and v2. The editing code needs to be tested.

@michelguerin
Copy link
Contributor

See #1581 - In review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants