Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name check in checkUpdateValidity cause strange behaviour when using complex action #672

Closed
dlabordus opened this issue Apr 5, 2022 · 4 comments
Labels
Kind: Bug Something isn't working Priority: Important Tackle eventually

Comments

@dlabordus
Copy link
Contributor

In the Substation Wizard we now use the Update Action to change the element instead of Replace Action.
The Update Action will hold all attributes that need to be preserve, including the name attribute.
There is already a check added to checkUpdateValidity (Editing.ts) to only check the name in case they are different (old <-> new).

When the check is executed and the same name is already used this is nicely logged in OpenSCD.
But also the Complex Action is logged, saying that the Substation has been updated.

Reproduct:

  • Open a SCD File in OpenSCD with at least 2 substations (or create a new one)
  • Change the name of the first substation in the same name used for the second substation
  • Updating fails, but a log entry saying the Substation is updated is also visible.
@dlabordus dlabordus added the Kind: Bug Something isn't working label Apr 5, 2022
@Sander3003
Copy link
Member

This needs to be discussed with @JakobVogelsang and/or @ca-d

@ca-d
Copy link
Contributor

ca-d commented Apr 11, 2022

@JakobVogelsang is still on vacation this week, and I'll not be available this Friday (public holiday in Germany), so maybe we should find a time slot to discuss this until Thursday.

I'd really like for this bug to be fixed, we always want the log to reflect what actually happened to the file. If it's not too urgent for you, I could contribute a fix next week on Friday at the latest.

@ca-d
Copy link
Contributor

ca-d commented May 24, 2022

@JakobVogelsang I'm afraid I lost sight of this bug, let's find a time to discuss this soon!

@michelguerin
Copy link
Contributor

This issue is deprecated because of the use of the new Event Api - see #1576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Bug Something isn't working Priority: Important Tackle eventually
Projects
None yet
Development

No branches or pull requests

5 participants