feat(type-designer): migrate plugin to independant plugin packages #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add open scd event
…ge inside plugins
michelguerin
force-pushed
the
feat/type-designer/migrate-to-plugin-package
branch
from
259d9ce to
1e2a1b6
Compare
michelguerin
requested review from
trusz and
fwagnerSE
and removed request for
trusz
fwagnerSE
reviewed
Oct 15, 2024
trusz
approved these changes
Oct 16, 2024
illia-solovei-s1
approved these changes
Oct 17, 2024
* feat(type-designer): add xml structure and sample file * feat(type-designer): add xml attributes to types in schema and test file * feat(plugin): prepare plugin abstraction to standardized create-plugin package * feat(core): renaming edition handler in plugin dev instance * feat(type-designer): add xml structure and sample file * feat(type-designer): add xml attributes to types in schema and test file * feat(type-designer): made change after review * change private attribute `name` to `type` * remove the root element to be more close to the standard * remove `LNodeType` as they are already part of the standard * change `TypesRefs` `to` attribute in favor of `type`
* Add plugin type instantication * Add plugin type conditional dev tool rendering * Remove default document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
These command should be written at the root of the monorepo.
To test in stand alone dev mode :
pnpm dev:type-designerTo test in integrated openscd instance mode :
pnpm dev:integrated:type-designerTo test storybook :
pnpm storybookNoticeable changes & logic :
plugin abstraction -> commit 42ae315
mui theme in new ui package -> commit d96e600
dev bar component (for local development) -> commit 72672a2
icon wrapper component