Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for JavaTemplate id is kept #3572

Closed
wants to merge 4 commits into from
Closed

Unit test for JavaTemplate id is kept #3572

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc03659
Unit test for JavaTemplate id is kept
BoykoAlex Sep 28, 2023
cd9b0f2
Merge branch 'main' into java-template-id
timtebeek Dec 2, 2023
10490fc
Merge branch 'main' into java-template-id
timtebeek Jul 28, 2024
629fb70
Update rewrite-java-test/src/test/java/org/openrewrite/java/JavaTempl…
timtebeek Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 42 additions & 4 deletions rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@
*/
package org.openrewrite.java;

import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.openrewrite.Cursor;
import org.openrewrite.DocumentExample;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Issue;
import org.openrewrite.*;
import org.openrewrite.internal.InMemoryLargeSourceSet;
import org.openrewrite.java.tree.*;
import org.openrewrite.test.RewriteTest;

Expand Down Expand Up @@ -1045,6 +1044,45 @@ void test() {
);
}

@Test
@Issue("https://github.com/openrewrite/rewrite/issues/3571")
@DisplayName("JavaTemplate should create a new instance with new id")
void javaTemplateShouldCreateANewInstanceWithNewId() {

RecipeRun run = new Recipe() {

@Override
public String getDisplayName() {
return null;
}

@Override
public String getDescription() {
return null;
}

@Override
public TreeVisitor<?, ExecutionContext> getVisitor() {
return new JavaIsoVisitor<>() {
@Override
public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
JavaTemplate javaTemplate = JavaTemplate.builder("@Deprecated").javaParser(JavaParser.fromJavaVersion()).build();
return javaTemplate.apply(getCursor(), classDecl.getCoordinates().addAnnotation((o1, o2) -> o1.getSimpleName().compareTo(o1.getSimpleName())));
}
};
}
}.run(new InMemoryLargeSourceSet(JavaParser.fromJavaVersion().build().parse("public class AClass {}").toList()), new InMemoryExecutionContext(t -> {
throw new RuntimeException(t);
}));

Result result = run.getChangeset().getAllResults().get(0);
J.ClassDeclaration classBefore = ((J.CompilationUnit) result.getBefore()).getClasses().get(0);
J.ClassDeclaration classAfter = ((J.CompilationUnit) result.getAfter()).getClasses().get(0);

assertThat(classBefore).isNotSameAs( classAfter);
assertThat(classBefore.getId()).isNotEqualTo( classAfter.getId());
}

@Test
void replaceMethodCallWithGenericParameterWithUnknownType() {
rewriteRun(
Expand Down
Loading