Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for JavaTemplate id is kept #3572

Closed
wants to merge 4 commits into from

Conversation

BoykoAlex
Copy link
Contributor

@BoykoAlex BoykoAlex commented Sep 28, 2023

@timtebeek timtebeek added bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail labels Sep 28, 2023
@timtebeek timtebeek marked this pull request as draft July 28, 2024 21:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-gradle/src/main/groovy/RewriteSettings.groovy
    • lines 31-36

…ateTest.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-gradle/src/main/groovy/RewriteSettings.groovy
    • lines 31-36

@timtebeek
Copy link
Contributor

Asked for more input over on #3571 (comment) to see when we can close out this PR.

@timtebeek
Copy link
Contributor

Closing this one as the underlying issue has since been closed too

@timtebeek timtebeek closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants