Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port scaling code from R to d3 #332

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Port scaling code from R to d3 #332

merged 7 commits into from
Apr 22, 2024

Conversation

rcannood
Copy link
Member

Describe your changes

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Preview succeeds and looks good!

Copy link

Deploy: success

@rcannood rcannood marked this pull request as ready for review April 22, 2024 12:45
@rcannood rcannood requested a review from KaiWaldrant April 22, 2024 12:45
Copy link
Contributor

@KaiWaldrant KaiWaldrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the read me otherwise LGTM!

@rcannood rcannood merged commit 940efc7 into main Apr 22, 2024
2 checks passed
@rcannood rcannood deleted the feature/no-ref/port-scaling branch April 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants