Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pandoc docker image from 3.2 to 3.6.3 #100

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Feb 10, 2025

This PR does the following:

  • Updates the dockerfile from 3.2 (2024-05-11) to 3.6.3 (2025-02-10)
  • Updates the LaTeX outputs with minor changes due to pandoc version bump, see explanation below
  • Debug issues in the example paper build workflow
  • [ ]

The new version of pandoc causes the following minor changes in latex output:

  1. Tables - tables are now sized with \linewidth instead of \columnwidth. This affects the tables captioned Basic inline markup and examples and Comparison of programming languages used in the publishing tool

  2. Inline Images - the width of the nyan-cat image and sylt images are now determined by the \linewidth instead of \textwidth. Inline images now get the keepaspectratio flag

  3. Free-standing Images - the mandrill image is now wrapped with\pandocbounded{}. Free-standing images now get the keepaspectratio flag.

    This command was introduced in Pandoc in jgm/pandoc@26b25a4 and lives in https://github.com/jgm/pandoc/blob/786356ace43d622866041f021b09452441ced009/data/templates/common.latex#L99-L108 in Pandoc 3.6.3. This requires adding the corresponding command to Inara's latex template

Blockers

It appears that two pre-existing issues that were suppressed by pandoc 3.2 are now causing failures for pandoc 3.6 (or at least, obscuring other errors that are happening with 3.6), so it would be nice to address these first in isolation:

@cthoyt cthoyt marked this pull request as draft February 10, 2025 10:39
@cthoyt cthoyt marked this pull request as ready for review February 10, 2025 10:56
@cthoyt cthoyt marked this pull request as draft February 10, 2025 11:07
@cthoyt cthoyt mentioned this pull request Feb 10, 2025
2 tasks
@cthoyt
Copy link
Contributor Author

cthoyt commented Feb 10, 2025

@xuanxu do you think you could take a look at this? It's strange that the compilation the test job works but the example PDF workflow does not

@cthoyt
Copy link
Contributor Author

cthoyt commented Feb 10, 2025

I think the issue is that latex needs to run twice, and it is erroring the first time when it hasn't taken a pass that it makes the citations https://github.com/openjournals/inara/actions/runs/13244251628/job/36966750145?pr=100#step:4:5417

@cthoyt cthoyt mentioned this pull request Feb 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant