Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example paper build workflow #101

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Feb 10, 2025

This PR was spun out from #100. It makes two improvements:

  • Updates the example paper build workflow to get triggered on changes to the Dockerfile, useful for testing.
  • Updates from actions/upload-artifact@v3 to actions/upload-artifact@v4 since v3 is deprecated, and GitHub Actions is aggressively rejecting jobs using it.

The draft and production zips generated by this updated workflow triggered on the commit in this PR can be found at https://github.com/openjournals/inara/actions/runs/13239708953

@cthoyt cthoyt force-pushed the update-example-workflow branch from 0d0f958 to a3b7d27 Compare February 10, 2025 11:17
@cthoyt cthoyt force-pushed the update-example-workflow branch from 0e7aa46 to bf243b4 Compare February 10, 2025 11:22
Copy link
Member

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xuanxu xuanxu merged commit 92554be into openjournals:main Feb 10, 2025
2 checks passed
@cthoyt cthoyt deleted the update-example-workflow branch February 10, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants