Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indentation #183

Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix indentation #183

merged 3 commits into from
Jun 10, 2024

Conversation

Sakurann
Copy link
Collaborator

resolves #133

examples/response/jarm_jwt_vc_json_post.txt Outdated Show resolved Hide resolved
Co-authored-by: Christian Bormann <[email protected]>
@Sakurann Sakurann requested a review from c2bo May 30, 2024 19:22
Copy link
Member

@c2bo c2bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, I do believe we need another pass at quite a few of the examples to get consistent indentation for everything, but the http request/response examples seem to be fine now.

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved
@Sakurann
Copy link
Collaborator Author

Sakurann commented Jun 3, 2024

Which examples..?

@c2bo
Copy link
Member

c2bo commented Jun 4, 2024

Which examples..?

https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-5.7-8 For example - header and body use different indentation. There were a few examples were e.g., the JSON formatting seemed to be different. I can take a bit of time and collect everything I find into another issue/PR.

@Sakurann
Copy link
Collaborator Author

I can take a bit of time and collect everything I find into another issue/PR.

@c2bo thank you - that would be great!

Co-authored-by: Christian Bormann <[email protected]>
@Sakurann Sakurann merged commit 376c57e into main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix indentation in example requests/responses
2 participants