Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent indentation of examples #190

Closed
c2bo opened this issue Jun 10, 2024 · 1 comment · Fixed by #192
Closed

Consistent indentation of examples #190

c2bo opened this issue Jun 10, 2024 · 1 comment · Fixed by #192
Assignees
@c2bo
Labels
editorial ready-for-PR

Comments

@c2bo
Copy link
Member

c2bo commented Jun 10, 2024

We still have some inconsistencies with the indentation of examples. Is everyone fine with defaulting to 2 spaces for everything?

Original comment can be found here:

https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-5.7-8 For example - header and body use different indentation. There were a few examples were e.g., the JSON formatting seemed to be different. I can take a bit of time and collect everything I find into another issue/PR.

Originally posted by @c2bo in #183 (comment)
@c2bo c2bo added the editorial label Jun 10, 2024
@c2bo
Copy link
Member Author

c2bo commented Jun 11, 2024

People seemed to be fine with 2 spaces in the WG call

@c2bo c2bo mentioned this issue Jun 12, 2024
Merged
@jogu jogu closed this as completed in #192 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c2bo c2bo

Labels
editorial ready-for-PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix indentation to use 2 spaces everywhere openid/OpenID4VP
2 participants
@c2bo @Sakurann