Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rtl] CSR cleanup #167

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[rtl] CSR cleanup #167

wants to merge 5 commits into from

Conversation

szbieg
Copy link

@szbieg szbieg commented Oct 25, 2023

Add/remove respective CSRs according to the CVE2 specification:

  • cycle,
  • instruction,
  • performance counters

szbieg and others added 2 commits October 18, 2023 15:32
@szbieg
cycle and instret CSR registers added
ef5ac87 
perf monitor event selector, cycle counters index 13..31 removed

Signed-off-by: Szymon Bieganski <[email protected]>
@szbieg
Merge branch 'openhwgroup:main' into feature/csrcleanup
79bf078
@szbieg szbieg marked this pull request as draft October 25, 2023 13:18
emgens
emgens approved these changes Oct 25, 2023
View reviewed changes
Copy link

@emgens emgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is very likely to resolve issue 166.
Removing the unused event counters is not strictly speaking necessary, and might make the code less general for future reuse; but that does not strike me a a reason not to approve.

@szbieg szbieg marked this pull request as ready for review November 16, 2023 13:58
@szbieg szbieg linked an issue Nov 28, 2023 that may be closed by this pull request
[BUG] User Mode Counters Not Implemented. #166
Open
This was referenced Dec 6, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgens emgens emgens approved these changes

@davideschiavone davideschiavone Awaiting requested review from davideschiavone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] User Mode Counters Not Implemented.
2 participants
@szbieg @emgens