Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-implemented CSR Check #2328

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

emgens
Copy link

@emgens emgens commented Dec 13, 2023

Added explicit check for non implemented CSR's to riscv_csr test.
Cleaned up cv32e20_csr_template.yaml.
This should run cleanly with cve2 pull request 167
There is an entry to work around issue 179, this should be removed once this issue is cleared.

Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @emgens. Really appreciate the README!

Question: when I run riscv_csr locally with Questasim it fails with this error message:

# ERROR: Unexpected illegal instruction while accessing CSR 0xc00

I assume that this is related to #166, is that correct?

@emgens
Copy link
Author

emgens commented Dec 13, 2023

LGTM @emgens. Really appreciate the README!

Question: when I run riscv_csr locally with Questasim it fails with this error message:

# ERROR: Unexpected illegal instruction while accessing CSR 0xc00

I assume that this is related to #166, is that correct?

It's #167, but yes. That pull request implements the user space CSR's, so you'll get this error if that isn't included.

@emgens
Copy link
Author

emgens commented Dec 15, 2023

There are known failures in this test case that should be resolved by CVE2 pull request #167

@MikeOpenHWGroup
Copy link
Member

Thanks @emgens. I will merge this in and add the riscv_csr test to the CI regression when cve2 #167 is resolved.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 439a0a6 into openhwgroup:cv32e20/dev Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants