SIMD clang builtin fixes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the immediate argument of the clang builtins for shuffle.sci.h and shuffle.sci.b to constant fold.
…ins. Add a check for the constant operands of SIMD clang builtins to be in range. This is added for the builtins: add.h, sub.h, shuffle.sci.h (the b version uses all the bits of the constant operand and so no need for a custom range check), cplxmul.r, cplxmul.i, subrotmj. Add test cases for the corresponding out of range errors. Use in range values in simd.c test for shuffle.sci.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the constant parameters type definition for the shuffle.sci.* clang builtins so that they constant fold.
It also adds a check on the value range of constant parameters for add.h, sub.h, shuffle.sci.h, cplxmul.r, cplxmul.i and subrotmj.
Finally it fixes the clang codegen test to use only in range values for the shuffle.sci.h test cases.