Fix addon name localisation before installation

[mherwege]

Fixes openhab/openhab-webui#2204
Replaces #3905

The issue is that no addon info is available for distribution addons before installation. The only thing available is the feature description and the addon endpoint gets it from the addon data, not the addonInfo data. So a merge of addonInfo is not even happening.
This change introduces a flag in AddonInfo indicating if it is the master info or not. When the info is coming from the addon repository scan, it is flagged to not be the master data and name and description will be ignored (because localization info is not available). Addon services will check if the addon info is master info, and only then update name and description.

[mherwege]

@andrewfg FYI
@kaikreuzer I think this should solve the isse.

[andrewfg]

I think this should solve the issue.

@mherwege / @kaikreuzer shall I do my usual full build clean install test before you merge it? i.e. tomorrow.

[kaikreuzer]

Thanks, let's have a try with this.

[andrewfg]

let's have a try with this.

@kaikreuzer / @mherwege all Ok; it works on my full build.

[jimtng]

@mherwege should we just revert this instead of #4572? isMasterAddon was added for the sole purpose that #4572 is removing. The only difference is the NA that would also get restored by reverting this.

Alternatively we could revert this, and then remove the NA stuff?

[mherwege]

@jimtng Indeed, I think this should be reverted. I don't think there is any harm in having the NA treatment back, and that keeps us on the safe side. It might be needed when loading if all providers are not available at the same time. I am not sure about that, so prefer keeping it.

If we revert this, is there a need to update the developer documentation to point out the name and description are required and they should be provided in full in the addon.xml? Reviewer instructions?

[jimtng]

If we revert this, is there a need to update the developer documentation to point out the name and description are required and they should be provided in full in the addon.xml? Reviewer instructions?

This one needs to be updated:
https://www.openhab.org/docs/developer/utils/i18n.html#using-custom-keys

[jimtng]

@mherwege I'll prepare a PR to revert this

[jimtng]

#4573