Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[addon] Fix localisation of suggested Add-ons" #3907

Closed
wants to merge 1 commit into from
Closed

Revert "[addon] Fix localisation of suggested Add-ons" #3907

wants to merge 1 commit into from

Conversation

kaikreuzer
Copy link
Member

Reverts #3905

@kaikreuzer kaikreuzer requested a review from a team as a code owner December 9, 2023 13:38
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 9, 2023
andrewfg
andrewfg approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as it were)

@mherwege
Copy link
Contributor

mherwege commented Dec 9, 2023

@kaikreuzer I created #3908 based on the current main state. It changes #3905. With that PR, it works in my tests. If it is accepted, no need to apply this revert.

@kaikreuzer kaikreuzer closed this Dec 9, 2023
@kaikreuzer kaikreuzer deleted the revert-3905-addon-fix-2204 branch December 9, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfg andrewfg andrewfg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kaikreuzer @mherwege @andrewfg