Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Limit device request failure condition #18136

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Jan 20, 2025

This change limits the device request failure condition introduced in #18087. Only request queries that were in sent and acked status should be considered for determining if a device failed to respond. If such query fails while waiting to be sent, it should not be considered as a device failure.

This should be backported.

@jsetton jsetton added the bug An unexpected problem or unintended behavior of an add-on label Jan 20, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit bf13465 into openhab:main Jan 20, 2025
2 checks passed
lsiepel pushed a commit that referenced this pull request Jan 20, 2025
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Jan 20, 2025
@lsiepel lsiepel added this to the 5.0 milestone Jan 20, 2025
@jsetton jsetton deleted the insteon-req-fail-limit branch January 21, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants