[insteon] Limit device request failure condition (#18136)

Signed-off-by: Jeremy Setton <[email protected]>
openhab · Jan 20, 2025 · 975d4ba · 975d4ba
1 parent 0f5bfe9
commit 975d4ba
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/...binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/BaseDevice.java b/...binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/BaseDevice.java
@@ -563,7 +563,6 @@ private long checkFeatureQueried(long now) {
      * @param feature the feature queried
      */
     protected void featureQueriedAnswered(DeviceFeature feature) {
-        // store current failed request count
         int prevCount = failedRequestCount;
         // reset failed request count
         failedRequestCount = 0;
@@ -583,8 +582,11 @@ protected void featureQueriedAnswered(DeviceFeature feature) {
      * @param feature the feature queried
      */
     protected void featureQueriedFailed(DeviceFeature feature) {
-        // increase failed request count
-        failedRequestCount++;
+        QueryStatus queryStatus = feature.getQueryStatus();
+        // increase failed request count if in sent or acked status
+        if (queryStatus == QueryStatus.QUERY_SENT || queryStatus == QueryStatus.QUERY_ACKED) {
+            failedRequestCount++;
+        }
         // mark feature queried as processed and never queried
         setFeatureQueried(null);
         feature.setQueryMessage(null);