Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction function compute_pivot_tables in ReformScenario #283

Merged
merged 13 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

# 2.0.4 [#283](https://github.com/openfisca/openfisca-survey-manager/pull/283)

- Correction function compute_pivot_tables in ReformScenario

# 2.0.3 [#282](https://github.com/openfisca/openfisca-survey-manager/pull/282)

- Correction typo error in create_data_frame_by_entity
Expand Down
8 changes: 6 additions & 2 deletions openfisca_survey_manager/scenarios/reform_scenario.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from openfisca_core.types import Array, Period

from openfisca_survey_manager.scenarios.abstract_scenario import AbstractSurveyScenario
from openfisca_survey_manager.simulations import Simulation


log = logging.getLogger(__name__)
Expand Down Expand Up @@ -182,7 +183,9 @@ def compute_pivot_table(self, aggfunc = 'mean', columns = None, difference = Fal
period = None, use_baseline = False, use_baseline_for_columns = None, values = None,
missing_variable_default_value = np.nan, concat_axis = None, weighted = True, alternative_weights = None):

return super(ReformScenario, self).compute_pivot_table(
filtering_variable_by_entity = self.filtering_variable_by_entity

return Simulation.compute_pivot_table(
aggfunc = aggfunc,
columns = columns,
baseline_simulation = self._get_simulation(use_baseline = True),
Expand All @@ -193,10 +196,11 @@ def compute_pivot_table(self, aggfunc = 'mean', columns = None, difference = Fal
difference = difference,
use_baseline_for_columns = use_baseline_for_columns,
values = values,
missing_variable_default_value = missing_variable_default_value.nan,
missing_variable_default_value = missing_variable_default_value,
concat_axis = concat_axis,
weighted = weighted,
alternative_weights = alternative_weights,
filtering_variable_by_entity = filtering_variable_by_entity
)

def compute_winners_loosers(self, variable = None,
Expand Down
23 changes: 23 additions & 0 deletions openfisca_survey_manager/tests/test_compute_pivot_table.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
from openfisca_survey_manager.tests.test_scenario import create_randomly_initialized_survey_scenario
from openfisca_country_template.reforms.modify_social_security_taxation import modify_social_security_taxation


def test_compute_pivot_table():
survey_scenario = create_randomly_initialized_survey_scenario(reform = modify_social_security_taxation)
period = "2017-01"

return survey_scenario.compute_pivot_table(
aggfunc = "mean",
columns = ['age'],
difference = False,
filter_by = None,
index = None,
period = period,
use_baseline = True,
use_baseline_for_columns = True,
values = ['salary'],
missing_variable_default_value = 0,
concat_axis = None,
weighted = True,
alternative_weights = None,
)
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

setup(
name = 'OpenFisca-Survey-Manager',
version = '2.0.3',
version = '2.0.4',
author = 'OpenFisca Team',
author_email = '[email protected]',
classifiers = [classifier for classifier in classifiers.split('\n') if classifier],
Expand Down