Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction function compute_pivot_tables in ReformScenario #283

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

Lolajossipp
Copy link
Contributor

Correction function compute_pivot_tables in ReformScenario

@Lolajossipp Lolajossipp requested review from benoit-cty, sylvainipp and clallemand and removed request for benoit-cty January 11, 2024 14:36
@clallemand
Copy link
Contributor

@benjello could you have a look to this PR ?

@benjello
Copy link
Member

There is obviously an error.
Thanks @Lolajossipp for catching it ! 😃

But the fix might not work if you use a ReformScenario without a reform simulation.
So you may want to use _get_simulation method to access the Simulation instances and use Simulation.compute_pivote_table to compute the pivot table.

Hope it helps.

@benjello
Copy link
Member

benjello commented Jan 12, 2024

@Lolajossipp : you can also add a specific test reproducing your use case.

@Lolajossipp
Copy link
Contributor Author

@clallemand

Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'idéal pour un test est d'avoir un assert pour tester spécifiquement un point.
Après si le temps presse ...

@benjello
Copy link
Member

@Lolajossipp : I had in mind adding an assert in the test you wrote. But it is not very important, you can move on and merge this PR if you are in a hurry.

@Lolajossipp Lolajossipp merged commit 5f3b802 into master Jan 17, 2024
10 checks passed
@benjello benjello deleted the corr_compute_pivot_tables branch January 18, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants