Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions to the EnsureWorkflows check + Docs Update #537

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jul 17, 2024

This check will make new PRs but there are times when we want to have certain repo/workflow exceptions where we don't want to mess with them from here and create extra churn. So add a way to track that info in the check so we can encode that info up front as we learn it.

Sample output:

docs.openedx.org: 
        Branch Protection with CLA Check is in Place. 'cla-checker' team has 'push' access.
        'openedx-triage' team has 'triage' access.
        All desired labels exist with the right name, color, description.
        All desired workflows are in sync with what's in the .github repo.
                Ignoring repo specific exceptions: ['commitlint.yml']
        No teams with `admin` or `maintain` permissions.
        All expected settings are set correctly.
        Steps:
                No changes needed.
        No user has direct repo access.

A new `exceptions` dictionary will now let us track repos/workflows that
we don't want to update because of repo-specific reasons.  This will
reduce the amount of PR churn caused by this check for repos where we
have known exceptions to the rules.
@feanil feanil changed the title docs: Add a note about rate limiting and restarting runs. Add exceptions to the EnsureWorkflows check + Docs Update Jul 17, 2024
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@feanil feanil merged commit db36a28 into master Jul 17, 2024
4 checks passed
@feanil feanil deleted the feanil/improve_docs branch July 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants