feat!: stop syncing labels from labels.yaml
#245
Closed
+13
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2023
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `blended`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `labels.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: openedx#218
kdmccormick
force-pushed
the
kdmccormick/stop-syncing-labels
branch
from
0cd5240
to
93584d6
Compare
|
I think it might be true that some of fake_github.py can also be removed now, since it emulates label REST API endpoints that we no longer use. It's not critical to remove it, but it will be unused code. |
|
This has been covered in #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels.
Note that the bot will still add and delete a handful of labels from PRs (
open-source-pull-request,core-committer, etc). What this commit changes is that the bot will not longer create nor delete labels from the entire repository.The
labels.yamlfile is now unused and can be safely deleted from any openedx-webhooks data repositories.[1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks
Part of: #218