Deprecate Label Creation in openedx-webhooks #218
Assignees
Labels
epic
Large unit of work, consisting of multiple tasks
Comments
|
Will be addressed on the terraform-github side by: openedx-unsupported/terraform-github#61 |
kdmccormick
added a commit
to kdmccormick/repo-tools-data-schema
that referenced
this issue
May 30, 2023
kdmccormick
added a commit
to openedx/repo-tools-data-schema
that referenced
this issue
May 31, 2023
This was prompted because we actually want LABELS to be empty as an intermediate step towards removing label creation from openedx-webhooks. Per the docs on https://pypi.org/project/schema/ (scroll down to "Dictionaries"), schema validation will fail on empty dictionaries unless you specifically make the schema `Or(<dict>, {})`. The only changes in this PR are wrapping each dict schema in `Or(..., {})`. I tested locally that this fixes openedx/openedx-webhooks-data#191 Part of openedx/openedx-webhooks#218
kdmccormick
added a commit
to openedx-unsupported/terraform-github
that referenced
this issue
May 31, 2023
This populates labels.yml with a list of labels that will be synced across the openedx GitHub organization. The labels will be synced by Axim using repo_checks.py. The labels' spelling, color, and description will be made consistent. If a repo has an existing label with similar spelling (that is: ignoring capitalization, emoji, spaces, and special characters) then the label will be edited in-place instead of created anew. So, we shouldn't have a bunch of old-spelling labels lying around when this is done. The proposed labels.yml is based on the comments on this wiki page: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3695214629 Relates to openedx/openedx-webhooks#218
kdmccormick
added a commit
to kdmccormick/openedx-webhooks
that referenced
this issue
Jun 17, 2023
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `core-committer`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `label.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: openedx#218
kdmccormick
added a commit
to kdmccormick/repo-tools-data-schema
that referenced
this issue
Jun 17, 2023
kdmccormick
added a commit
to kdmccormick/openedx-webhooks
that referenced
this issue
Jun 17, 2023
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `blended`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `labels.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: openedx#218
nedbat
pushed a commit
that referenced
this issue
Jul 25, 2023
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `blended`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `labels.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: #218
nedbat
pushed a commit
that referenced
this issue
Jul 25, 2023
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `blended`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `labels.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: #218
|
@feanil the original 6 tasks are now done. |
|
Seems like this can close, there is follow up work but the two ticket items can be done later. The third followup doesn't seem relevant anymore since we've dropped all the label management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The openedx-webhooks repo creates labels for any repos that it receives PRs from. This is useful but now that we're also using a lot of repos as a way of holding related github issues, we need something a bit more robust.
openedx-unsupported/terraform-github#44 adds a robust way to create labels on all repos within the organization.
To reduce the chances of confusion and dueling automation, we should only have one way to manage labels we want to systematically create for all the repos in the org. Since the terraform-github check is more robust, we should move forward with that and migrate any labels that openedx-webhooks creates to that script. This includes the labels defined in https://github.com/openedx/openedx-webhooks-data/blob/main/labels.yaml as well as any defined in the openedx-webhooks code.
Tasks
labels.yaml#245validate_labelsrepo-tools-data-schema#30Followup
The text was updated successfully, but these errors were encountered: