Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update standard workflow files. #47

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update standard workflow files. #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/commitlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
name: Lint Commit Messages

on:
push:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril looks like this is different from the standard, was there a specific reason for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was changed in #29 and I didn't think much of it then. @OmarIthawi do you remember why this change was made?

Copy link
Member

@OmarIthawi OmarIthawi Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember either. Let's merge this pull request and standardize it. If the next semantic-release fails, we can revert this pull request and document the reason of the failure.

I could be due to some obscure semantic-release requirement, but now I doubt it. It's probably just a left-over from multiple attempts to get the workflow correct.

branches: [ "main" ]
pull_request:
branches:
- '**'
- pull_request

jobs:
commitlint:
Expand Down