Update standard workflow files. #47
Conversation
The .github/workflows/commitlint.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org.
| @@ -3,11 +3,7 @@ | |||
| name: Lint Commit Messages | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
@brian-smith-tcril looks like this is different from the standard, was there a specific reason for this?
There was a problem hiding this comment.
Looks like it was changed in #29 and I didn't think much of it then. @OmarIthawi do you remember why this change was made?
There was a problem hiding this comment.
I don't remember either. Let's merge this pull request and standardize it. If the next semantic-release fails, we can revert this pull request and document the reason of the failure.
I could be due to some obscure semantic-release requirement, but now I doubt it. It's probably just a left-over from multiple attempts to get the workflow correct.
| @@ -3,11 +3,7 @@ | |||
| name: Lint Commit Messages | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
I don't remember either. Let's merge this pull request and standardize it. If the next semantic-release fails, we can revert this pull request and document the reason of the failure.
I could be due to some obscure semantic-release requirement, but now I doubt it. It's probably just a left-over from multiple attempts to get the workflow correct.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR was created automatically by the
repo_checkstool.