Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate enzyme to react-unit-test-utils #378

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Jan 18, 2024

Description

This PR migrates the enzyme to @edx/react-unit-test-utils.

What changed?

  • [ More in depth breakdown of changes ]
  • [ Peripheral things that got changed ]
  • [ etc... ]

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Jan 18, 2024
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi requested a review from a team as a code owner January 18, 2024 08:17
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7884761) 94.98% compared to head (e70a6d2) 94.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         140      140           
  Lines        1356     1356           
  Branches      264      264           
=======================================
  Hits         1288     1288           
  Misses         60       60           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi merged commit 3384985 into master Jan 30, 2024
7 checks passed
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi deleted the Ali-Abbas/enzyme-deprecation branch January 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants