[DEPR]: Enzyme #195
Comments
|
@adamstankiewicz before we merge this, I would love to add more guidance here on how to migrate away from enzyme. I would like to amend the "Replacement" section with something like this: "Replacing an enzyme test with react-testing-library means rewriting a lot of code. Thus, for existing tests that you don't want to completely rewrite, we recommend using @muselesscreator 's https://github.com/muselesscreator/react-unit-test-utils as a wrapper for react-test-renderer that can for the most part act as a drop-in-replacement for enzyme without too much work. For new tests, we recommend using react-testing-library at least partially. It allows you also to test multiple components together, test behavior as it appears to users in the browser, and test stateful components, which is not supported by react-test-renderer." |
|
@Syed-Ali-Abbas-Zaidi, I notice you've been doing this migration accross a few MFEs. Do you see any PRs missing from the list in the description? Are you aware of any MFEs or libraries where the migration hasn't been done, yet? |
List of MFEs that still need to be migrated: |
|
@arbrandes What is the current status of this? Should we move it into 'removing'? |
|
Since it seems like this is not active and the owners are not being responsive, we're going to move this back into 'Proposed' edit: Rescinding previous comment since @feanil took ownership of it. |
|
@MaxFrank13 can you provide some more info, it sounds like your repos are already on React Testing Library and so your issues are unrelated to enzyme? Maybe I missed something? |
|
Yes you're right. It's not directly related. It's just that deprecating Enzyme helps clear the way for React 18, and until then, we have to stay on React Testing Library v12 (the latest is v16). Other than Renovate merging those PRs with conflicts, this isn't really causing problems other than preventing us from staying up to date. The only issue I've been able to find that is referencing React 18 upgrades is one for the React 17 upgrade in platform-roadmap, and this Enzyme deprecation issue. Perhaps I'm not looking in the right places or maybe the work just hasn't been prioritized yet. Worth noting that Enzyme isn't the only blocker for React 18. We'd still need to upgrade other FE dependencies/peerDependencies in places like |
|
It sounds like what you actually care about is tracking openedx/platform-roadmap#277 which you're right is not currently being lead/in-progress anymore. My recommendation is that if there are specifics preventing upgrades in repos you care about to create issues in those repos about the specific upgrades that need to happen and to work with the maintainers to plan/take-on that work. If you need help with that please let me know but it sounds like your issue is more that "We're not on react 18 yet in learner record and profile" but the root cause of that is not the fact that those repos are still running "Enzyme" but some other blocker or just scheduling the work to do the upgrade. |
|
Ahh thanks for the suggestion. I think I incorrectly assumed that upgrades to |
Proposal Date
2023-05-31
Target Ticket Acceptance Date
2023-06-16
Earliest Open edX Named Release Without This Functionality
Quince - 2023-10
Rationale
Enzyme was largely the tool of choice for most JS tests throughout the Open edX platform until React
testing-librarycame out, which afforded developers a simpler way to write tests that more closely resembled how the web pages are used in practice by largely not relying on internal implementation details of the component. See https://testing-library.com/docs/guiding-principles/ for more details abouttesting-library's philosophy.However, while most new tests being written throughout Open edX are using React
testing-library, there stills exists a large number of Enzyme tests. Having these tests around would usually not be an issue, but it has recently come to our attention that Enzyme is no longer maintained; its maintainers and the community have publicly mentioned there are no plans to create a React 18 adapter for Enzyme. See more details here: https://dev.to/wojtekmaj/enzyme-is-dead-now-what-eklWhile it does not have any immediate impact on Open edX given it is largely running either React 16 and/or 17, Enzyme's lack of support for React 18 will impact and block an imminent upgrade to React 18 in the future.
Removal
Any repository which intends to upgrade to React 18 will need to remove its usage of Enzyme throughout its test suites. These Enzyme tests may be refactored using the suggestions made below.
Replacement
We recommend the use of React
testing libraryand/orreact-test-renderer.Existing tests that rely on Enzyme will need to be refactored to use an alternative like React
testing-libraryprior to any attempts to upgrade to React 18.Deprecation
Stub: we may be able to include build-time deprecation warnings within
@edxfrontend-buildto detect when a consuming MFE is using Enzyme based on whether it's installed in the MFE'spackage.jsonfile.Migration
Incremental migration is acceptable. Open edX is currently running React 16 in most places, but React 17 in a handful of others. Once React 18 becomes more imminent, refactoring away from Enzyme will become more important to not become a blocker for a future React 18 upgrade.
Additional Info
Outstanding Issues
Issues
enzymetoreact-testing-libraryparagon#2325PRs
The text was updated successfully, but these errors were encountered: