-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjusted grade field validation #365
feat: adjusted grade field validation #365
Conversation
Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@Inferato looks like there are some test failures, can you have a look. |
Hi @Inferato! Just following up on the failing check. |
@mphilbrick211 @e0d This PR should be closed in favor of #381 where I updated the test snapshot. |
Closing per comment above. |
@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR - added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:
Related: master
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora