Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lytvynenko/grade field validation master #364

Conversation

Inferato
Copy link

@Inferato Inferato commented Oct 23, 2023

TL;DR - added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:

  • enter only a numeric value
  • setting the minimum value
  • checking the correctness of the entered value to possibleGrade

Related: open-release/quince.master

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@Inferato Inferato requested a review from a team as a code owner October 23, 2023 13:55
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 23, 2023

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 23, 2023
@e0d
Copy link

e0d commented Oct 24, 2023

@Inferato looks like there are some test failures.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@mphilbrick211
Copy link

@Inferato looks like there are some test failures.

Hi @Inferato! Flagging this for you :)

@mphilbrick211
Copy link

Hi @Inferato - flagging the failing check here. Thanks!

@mphilbrick211
Copy link

Hi @Inferato - flagging the failing check here. Thanks!

Hi @Inferato - just following up on this!

@dyudyunov
Copy link
Contributor

@e0d @mphilbrick211

Sorry for the delays, Taras is no longer a member of RG.
Currently, I'm gathering all the PRs he worked on. I will check their statuses and update them if necessary.

I will leave the status update comments on each PR's comments ASAP

@dyudyunov
Copy link
Contributor

@e0d @mphilbrick211 could you close this PR in favor of #382?

I updated the snapshot and increased the test coverage there

@mphilbrick211
Copy link

Closing per comment above.

@openedx-webhooks
Copy link

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants