Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable taxonomy/tagging feature in MFE by default #989

Merged

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented May 8, 2024

Description

This PR sets the tagging feature as enabled by default. The ENABLE_TAGGING_TAXONOMY_PAGES environment variable (along with the content_tagging.disabled waffle flag) can still be used to turn it off when necessary.

Supporting information

Relates to openedx/edx-platform#34633

Replaces #971 as I'm worried about the performance implications of that one; this one is a dead simple env var, rather than loading waffle flag data from the LMS.

Testing instructions

Override the ENABLE_TAGGING_TAXONOMY_PAGES variable to false, and make sure no tagging functionality appears in the MFE.

Other information

Before merging: make sure 2U sets the env var to false on edx.org because they aren't ready to launch this feature yet.

But otherwise, we want it on by default for developers and all users of the Redwood release.

@bradenmacdonald bradenmacdonald requested a review from a team as a code owner May 8, 2024 18:07
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 8, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (087c82c) to head (c1b83be).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         703      703           
  Lines       12361    12363    +2     
  Branches     2682     2680    -2     
=======================================
+ Hits        11399    11401    +2     
  Misses        926      926           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald bradenmacdonald force-pushed the braden/alternate-tagging-by-default branch from a445620 to 42a7e7d Compare May 8, 2024 18:24
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Looks good 👍

  • I tested this: I testest the default value, and I testes disabling the value.
  • I read through the code and considered the security, stability and performance implications of the changes.
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

Copy link
Member

@jesperhodge jesperhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Always makes me very happy when something is well-tested like here.

@bradenmacdonald
Copy link
Contributor Author

Thanks @jesperhodge! Would you mind merging this once you're confirmed it's overridden to false (disabled) on edx.org ?

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@arbrandes arbrandes merged commit 14245bc into openedx:master May 8, 2024
6 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants