feat: Enable taxonomy/tagging feature in MFE by default

[rpenido]

Description

This PR sets the tagging feature as enabled by default and creates a new waffle flag, content_tagging.disabled, to allow the feature to be turned off.

More Information

• feat: Enable taxonomy/tagging feature in MFE by default edx-platform#34633

Testing Instructions

See openedx/edx-platform#34633

[openedx-webhooks]

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.22%. Comparing base (087c82c) to head (5b19f45).

Files	Patch %	Lines
src/taxonomy/TaxonomyListPage.jsx	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   92.21%   92.22%           
=======================================
  Files         703      703           
  Lines       12361    12382   +21     
  Branches     2682     2649   -33     
=======================================
+ Hits        11399    11419   +20     
- Misses        926      927    +1     
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusuf-musleh]

@rpenido Great work on this it's on the right path, just faced a few issues and have some suggestions below.

The "Manage tags" and tag counts are always present, regardless of whether the new waffle flag is set or not, see my comment below. The taxonomies tab however appears/disappears as expected.

[yusuf-musleh]

This always seems to be falling back to false since the env variable is not being set, regardless of whether the flags is set in the edx-platform or not. So the "Manage Tags" and tags counts always show regardless if the new waffle flag is set or not.

The previous flag has the following env variables set:

https://github.com/openedx/frontend-app-course-authoring/blob/65f45f72f08c1f38ced5d8d302fbdd2406da228d/.env#L36

https://github.com/openedx/frontend-app-course-authoring/blob/65f45f72f08c1f38ced5d8d302fbdd2406da228d/.env.development#L39

https://github.com/openedx/frontend-app-course-authoring/blob/65f45f72f08c1f38ced5d8d302fbdd2406da228d/.env.test#L34

Since it currently doens't seem to be reading it from the edx-platform backend, I'm not sure what the general practice is for this, however maybe we could utilize the taxonomiesEnabled flag that is passed in from the backend:

https://github.com/openedx/frontend-app-course-authoring/blob/65f45f72f08c1f38ced5d8d302fbdd2406da228d/src/studio-home/tabs-section/index.jsx#L32-L37

[rpenido]

Hi @yusuf-musleh!

I think getting the data from the backend is the right approach, but we need to fetch a lot of data to use this selector.

I created a new hook (using react-query) that solves that problem. The only issue is that we need this info in the index.jsx, where we don't have the necessary configs just to call a hook.

We may need to use some kind of "lazy load" for the routes. Maybe @bradenmacdonald could help us with some ideas?

[bradenmacdonald]

hey guys, I don't know if there is a good pattern for this now. I think we should just stick to the simplest option and have an environment variable that disables the MFE features (getConfig().DISABLE_TAGGING_FEATURE) and a waffle flag that controls the legacy UI (content_tagging.disabled).

The waffle flag is already set on edx.org, in anticipation of this PR, but we'll also have to get them to set the env var once it's confirmed.

[bradenmacdonald]

Actually I like @rpenido's approach and I think it's even better if we can get it to work. Which index.jsx is the problem? The studio home page or the taxonomies page?

[rpenido]

The root index, where we declare the <App>.

One "easy" approach to avoid this problem (needing a provider at the App level) is to move the check to the destination pages, showing an error message or redirecting to another place if the flag is disabled. I think this is not the best solution, but it will work.

[bradenmacdonald]

That's fine. We want most people using this, and having it disabled will be fairly rare. The important thing is that reading this flag doesn't slow down the frontend, so shouldn't introduce an additional blocking API request on every page.

[bradenmacdonald]

One "easy" approach to avoid this problem (needing a provider at the App level) is to move the check to the destination pages, showing an error message or redirecting to another place if the flag is disabled.

So let's go with that.

[bradenmacdonald]

OK, I implemented that ^

@yusuf-musleh could you please review/test this PR again?

[bradenmacdonald]

@yusuf-musleh I have finished this up and it's ready for review again

[yusuf-musleh]

👍 @bradenmacdonald I tested it out, its working well. There was just the unit side bar tags that was missing the check if tagging was enabled/disabled, but I went ahead
and added it here: 5d37761

• I tested this: Followed the testing instructions in the edx-platform PR
• I read through the code
• I checked for accessibility issues
• Includes documentation

[bradenmacdonald]

Thinking about this more, I'm worried about the performance implications of loading the studio home data on every page since it's consumed by the updated header. I'm going to suggest we keep it simple and use an env var instead: #989

[openedx-webhooks]

@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.